Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AC_AttitudeControl: use AC_PID defaults to tidy rate Sub PID initialisation #28161

Merged
merged 1 commit into from
Sep 24, 2024
Merged

AC_AttitudeControl: use AC_PID defaults to tidy rate Sub PID initialisation #28161

merged 1 commit into from
Sep 24, 2024

Conversation

peterbarker
Copy link
Contributor

makes it look like multi ie. legible

We need to reorder initialisation in the PID iniit method being used in the old code. This change means one less place to get right.

@peterbarker
Copy link
Contributor Author 

Board                    AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
CubeOrange-periph-heavy  *                                                                     
Durandal                            *      *           *       *                 *      *      24
Hitec-Airspeed           *                                                                     
KakuteH7-bdshot                     *      *           *       *                 *      *      -32
MatekF405                           *      *           *       *                 *      *      -48
Pixhawk1-1M-bdshot                  *                  *       *                 *      *      -24
f103-QiotekPeriph        *                                                                     
f303-Universal           *                                                                     
iomcu                                                                *                         
revo-mini                           *      *           *       *                 *      *      -40
skyviper-v2450                                         *

IamPete1
IamPete1 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@IamPete1 IamPete1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tridge tridge merged commit 6a74a97 into ArduPilot:master Sep 24, 2024
95 checks passed
@peterbarker peterbarker deleted the pr/sub-pid-construction branch September 24, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IamPete1 IamPete1 IamPete1 approved these changes

@Williangalvani Williangalvani Williangalvani approved these changes

Assignees
No one assigned
Labels
Sub
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@peterbarker @Williangalvani @IamPete1 @tridge @CraigElder